[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH V6 26/32] pci: use range helper functions.
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH V6 26/32] pci: use range helper functions. |
Date: |
Tue, 10 Nov 2009 17:59:32 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Fri, Oct 30, 2009 at 09:21:20PM +0900, Isaku Yamahata wrote:
> clean up pci_default_write_config() by the range helper functions.
>
> Suggested by Michael S. Tsirkin <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Isaku Yamahata <address@hidden>
Mabe you can float this patch up so I can put it on pci tree.
> ---
> hw/pci.c | 8 ++------
> 1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index 67133b6..d9fd564 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -699,19 +699,15 @@ uint32_t pci_default_read_config(PCIDevice *d,
>
> void pci_default_write_config(PCIDevice *d, uint32_t addr, uint32_t val, int
> l)
> {
> - uint8_t orig[PCI_CONFIG_SPACE_SIZE];
> int i;
> uint32_t config_size = pci_config_size(d);
>
> - /* not efficient, but simple */
> - memcpy(orig, d->config, PCI_CONFIG_SPACE_SIZE);
> for(i = 0; i < l && addr < config_size; val >>= 8, ++i, ++addr) {
> uint8_t wmask = d->wmask[addr];
> d->config[addr] = (d->config[addr] & ~wmask) | (val & wmask);
> }
> - if (memcmp(orig + PCI_BASE_ADDRESS_0, d->config + PCI_BASE_ADDRESS_0, 24)
> - || ((orig[PCI_COMMAND] ^ d->config[PCI_COMMAND])
> - & (PCI_COMMAND_MEMORY | PCI_COMMAND_IO)))
> + if (ranges_overlap(addr, l, PCI_BASE_ADDRESS_0, 24) ||
> + range_covers_byte(addr, l, PCI_COMMAND))
> pci_update_mappings(d);
> }
>
> --
> 1.6.0.2
>
>