[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH V6 08/32] pci: clean up pci_init_wmask()
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] Re: [PATCH V6 08/32] pci: clean up pci_init_wmask() |
Date: |
Tue, 10 Nov 2009 17:26:13 +0200 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Fri, Oct 30, 2009 at 09:21:02PM +0900, Isaku Yamahata wrote:
> use pci_set_word() for pci command register.
>
> Signed-off-by: Isaku Yamahata <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
I thought I acked this already. It's an obvious one.
> ---
> hw/pci.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci.c b/hw/pci.c
> index 6abb0e2..84c7611 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -352,8 +352,8 @@ static void pci_init_wmask(PCIDevice *dev)
> int i;
> dev->wmask[PCI_CACHE_LINE_SIZE] = 0xff;
> dev->wmask[PCI_INTERRUPT_LINE] = 0xff;
> - dev->wmask[PCI_COMMAND] = PCI_COMMAND_IO | PCI_COMMAND_MEMORY
> - | PCI_COMMAND_MASTER;
> + pci_set_word(dev->wmask + PCI_COMMAND,
> + PCI_COMMAND_IO | PCI_COMMAND_MEMORY | PCI_COMMAND_MASTER);
> for (i = PCI_CONFIG_HEADER_SIZE; i < PCI_CONFIG_SPACE_SIZE; ++i)
> dev->wmask[i] = 0xff;
> }
> --
> 1.6.0.2
>
>