qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 2/7] Introduce QError


From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH 2/7] Introduce QError
Date: Thu, 29 Oct 2009 23:08:28 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4

On 10/29/2009 09:48 PM, Luiz Capitulino wrote:
>  va_list doesn't need to be a pointer.

  Ok, but if this is going to be a public interface, I think it's
better to va_copy() before passing it to qobject_from_json_va() then.

It is standard to pass a va_list by value without doing va_copy in the caller.

>  Shouldn't this take a ... too?
  The problem is that its caller (qemu_error_structed()) also takes
a ..., I don't know how to pass the arguments to a second function with
variadic arguments w/o passing the va_list.

Yeah, this is fine.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]