[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] Pass the drive's readonly attribute to the guest OS
From: |
Naphtali Sprei |
Subject: |
[Qemu-devel] [PATCH] Pass the drive's readonly attribute to the guest OS |
Date: |
Thu, 29 Oct 2009 11:42:11 +0200 |
User-agent: |
Thunderbird 2.0.0.23 (X11/20090817) |
Hi,
I've seen my patch
(http://repo.or.cz/w/qemu/aliguori-queue.git?a=commit;h=2286b94c7458cd6d72883990b53500194975c2ff)
in the staging tree, but the patch relies on a previous patch
(http://lists.gnu.org/archive/html/qemu-devel/2009-10/msg01316.html)
I sent that I cannot find in the staging tree, nor committed.
So here is the missing patch again, against current head.
Naphtali
Subject: [PATCH] Pass the drive's readonly attribute to the guest OS
Implemented for virtio-blk and for scsi
Signed-off-by: Naphtali Sprei <address@hidden>
---
hw/scsi-disk.c | 3 ++-
hw/virtio-blk.c | 3 +++
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 2a9268a..5da573d 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -633,7 +633,8 @@ static int32_t scsi_send_command(SCSIDevice *d, uint32_t
tag,
memset(p, 0, 4);
outbuf[1] = 0; /* Default media type. */
outbuf[3] = 0; /* Block descriptor length. */
- if (bdrv_get_type_hint(s->dinfo->bdrv) == BDRV_TYPE_CDROM) {
+ if (bdrv_get_type_hint(s->dinfo->bdrv) == BDRV_TYPE_CDROM ||
+ bdrv_is_read_only(s->dinfo->bdrv)) {
outbuf[2] = 0x80; /* Readonly. */
}
p += 4;
diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
index 2630b99..e6df9f2 100644
--- a/hw/virtio-blk.c
+++ b/hw/virtio-blk.c
@@ -444,6 +444,9 @@ static uint32_t virtio_blk_get_features(VirtIODevice *vdev)
#endif
if (strcmp(s->serial_str, "0"))
features |= 1 << VIRTIO_BLK_F_IDENTIFY;
+
+ if (bdrv_is_read_only(s->bs))
+ features |= 1 << VIRTIO_BLK_F_RO;
return features;
}
--
1.6.3.3
- Re: [Qemu-devel] [PATCH] Pass the drive's readonly attribute to the guest OS, (continued)
- Re: [Qemu-devel] [PATCH] Pass the drive's readonly attribute to the guest OS, Naphtali Sprei, 2009/10/14
- Re: [Qemu-devel] [PATCH] Pass the drive's readonly attribute to the guest OS, Kevin Wolf, 2009/10/15
- Re: [Qemu-devel] [PATCH] Pass the drive's readonly attribute to the guest OS, Gleb Natapov, 2009/10/15
- Re: [Qemu-devel] [PATCH] Pass the drive's readonly attribute to the guest OS, Kevin Wolf, 2009/10/15
- Re: [Qemu-devel] [PATCH] Pass the drive's readonly attribute to the guest OS, Gleb Natapov, 2009/10/15
- Re: [Qemu-devel] [PATCH] Pass the drive's readonly attribute to the guest OS, Kevin Wolf, 2009/10/15
- Re: [Qemu-devel] [PATCH] Pass the drive's readonly attribute to the guest OS, Gleb Natapov, 2009/10/15
- Re: [Qemu-devel] [PATCH] Pass the drive's readonly attribute to the guest OS, Kevin Wolf, 2009/10/15
- Re: [Qemu-devel] [PATCH] Pass the drive's readonly attribute to the guest OS, Gleb Natapov, 2009/10/15
- Re: [Qemu-devel] [PATCH] Pass the drive's readonly attribute to the guest OS, Kevin Wolf, 2009/10/15
[Qemu-devel] [PATCH] Pass the drive's readonly attribute to the guest OS,
Naphtali Sprei <=