|
From: | Avi Kivity |
Subject: | [Qemu-devel] Re: [PATCH] Use msr list to load and save msrs |
Date: | Tue, 27 Oct 2009 12:01:59 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 |
On 10/26/2009 08:26 PM, Glauber Costa wrote:
+ + kvm_msr_list = kvm_get_msr_list(env); + if (!kvm_msr_list) { + printf("FAILED\n"); + return -1; + } + + msr_data.info.nmsrs = kvm_msr_list->nmsrs; + + for (i = 0; i< kvm_msr_list->nmsrs; i++) { + uint64_t *data = kvm_get_msr_data_addr(env, kvm_msr_list->indices[i]); + msrs[i].index = kvm_msr_list->indices[i]; + if (data != NULL) { + msrs[i].data = *data; + } + } return kvm_vcpu_ioctl(env, KVM_SET_MSRS,&msr_data);
Aren't you leaking the msr list structure? Best to get it once during setup and reuse it later. -- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |