Re: [Qemu-devel] Re: [PATCH 01/10] Introduce qmisc module

[Paolo Bonzini]

On 10/18/2009 06:32 PM, Anthony Liguori wrote:
> What's the value of integrating into the objects verses having a
> separate function that can apply it to the objects?

That's just different style.  Of course you could do a 
switch(qobject_type(qobject)) instead of using polymorphism.  It would 
be nicer in some ways, and uglier in other ways.  toString however seems 
pervasive enough that it could deserve a place as a QObject virtual method.

Anyway, I probably won't have much code in QEMU in the end, so there's 
no value in arguing when anyway a very nice design is emerging.  It 
looks like Anthony has most of the JSON plumbing in his brain, so it's 
better if he keeps the flow going.  Feel free to steal my code.

Once your stuff is settled I'll see what's missing and rebase/resend.

Paolo, at one point tempted to s/encode_json/to_string/ and resubmit :-)