qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] target-arm: fix sdiv helper


From: Aurelien Jarno
Subject: [Qemu-devel] [PATCH] target-arm: fix sdiv helper
Date: Thu, 15 Oct 2009 23:08:46 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

(INT32_MIN / -1) triggers an overflow, and the result depends on the
host architecture (INT32_MIN on arm, -1 on ppc, SIGFPE on x86). Use a
test to output the correct value.

Signed-off-by: Aurelien Jarno <address@hidden>
---
 target-arm/helper.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/target-arm/helper.c b/target-arm/helper.c
index 701629a..b3d6198 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -404,6 +404,8 @@ int32_t HELPER(sdiv)(int32_t num, int32_t den)
 {
     if (den == 0)
       return 0;
+    if (num == INT_MIN && den == -1)
+      return INT_MIN;
     return num / den;
 }
 
-- 
1.6.1.3





reply via email to

[Prev in Thread] Current Thread [Next in Thread]