[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 5/9] monitor: QError support
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] Re: [PATCH 5/9] monitor: QError support |
Date: |
Wed, 14 Oct 2009 16:07:11 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 10/13/2009 11:59 PM, Markus Armbruster wrote:
>>> > +void qemu_error_structed(QErrorCode code, const char *fmt, ...);
>> Needs __attribute__((format(printf, 2, 3))).
>
> If I read the code correctly, qemu_object_from_va is what in the end
> processes the valist and it is not exactly compatible with printf
> syntax. For example, in patch 7/9 you have
>
> qemu_error_structed(QERR_QDEV_NFOUND, "{ s: s }", "name", driver);
You're right, of course.
Pity we lose the checking.
[Qemu-devel] [PATCH 6/9] QError: Add qdev not found error, Luiz Capitulino, 2009/10/13
- Re: [Qemu-devel] [PATCH 6/9] QError: Add qdev not found error, Hollis Blanchard, 2009/10/14
- Re: [Qemu-devel] [PATCH 6/9] QError: Add qdev not found error, Luiz Capitulino, 2009/10/15
- Re: [Qemu-devel] [PATCH 6/9] QError: Add qdev not found error, Hollis Blanchard, 2009/10/15
- Re: [Qemu-devel] [PATCH 6/9] QError: Add qdev not found error, Luiz Capitulino, 2009/10/15
- Re: [Qemu-devel] [PATCH 6/9] QError: Add qdev not found error, Hollis Blanchard, 2009/10/15
- Re: [Qemu-devel] [PATCH 6/9] QError: Add qdev not found error, Luiz Capitulino, 2009/10/15
- Re: [Qemu-devel] [PATCH 6/9] QError: Add qdev not found error, Hollis Blanchard, 2009/10/15
- Re: [Qemu-devel] [PATCH 6/9] QError: Add qdev not found error, Anthony Liguori, 2009/10/15
- Re: [Qemu-devel] [PATCH 6/9] QError: Add qdev not found error, Hollis Blanchard, 2009/10/15