Re: [Qemu-devel] [PATCH 4/4] use rom loader for pc bios.

[Gerd Hoffmann]

> >       bios_offset = qemu_ram_alloc(bios_size);
> > -    ret = load_image(filename, qemu_get_ram_ptr(bios_offset));
> > -    if (ret != bios_size) {
> > +    ret = rom_add_file_fixed(bios_name, (uint32_t)(-bios_size));
>
> Memory leak?

I don't think so.

> AFAICS the qemu_ram_alloc above should be removed and maybe
> bios_offset needs to be killed completely.

Why?  You still need the memory for the bios rom, even if the way it 
gets loaded changes.

cheers,
  Gerd