[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic |
Date: |
Thu, 08 Oct 2009 17:53:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Avi Kivity wrote:
> On 10/08/2009 03:49 PM, Anthony Liguori wrote:
>> Glauber Costa wrote:
>>> This patch provides kvm with an in-kernel ioapic. We are currently
>>> not enabling it.
>>> The code is heavily based on what's in qemu-kvm.git.
>>
>> It really ought to be it's own file and own device model. Having the
>> code mixed in with ioapic.c is confusing because it's unclear what
>> code is in use when the in-kernel model is used.
>
> I disagree. It's the same device with the same guest-visible interface
> and the same host-visible interface (save/restore, 'info ioapic' if we
> write one). Splitting it into two files will only result in code
> duplication.
Shared functions can be pushed into a commonly used module
(ioapic-common.c). And everyone touching it should realize then that it
could affect more than one user.
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
- Re: [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic, (continued)
- Re: [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic, Anthony Liguori, 2009/10/08
- Re: [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic, Avi Kivity, 2009/10/08
- Re: [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic, Anthony Liguori, 2009/10/08
- Re: [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic, Glauber Costa, 2009/10/08
- Re: [Qemu-devel] Re: [PATCH v2 4/9] provide in-kernel apic, Glauber Costa, 2009/10/08
- [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic, Jan Kiszka, 2009/10/08
- [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic, Anthony Liguori, 2009/10/08
- [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic, Avi Kivity, 2009/10/08
- [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic,
Jan Kiszka <=
- Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic, Jamie Lokier, 2009/10/08
- Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic, Anthony Liguori, 2009/10/08
- Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic, Avi Kivity, 2009/10/08
- Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic, Gleb Natapov, 2009/10/08
- Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic, Avi Kivity, 2009/10/08
- Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic, Gleb Natapov, 2009/10/08
- Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic, Avi Kivity, 2009/10/08
- Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic, Gleb Natapov, 2009/10/08
- Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic, Jamie Lokier, 2009/10/09
- Re: [Qemu-devel] Re: [PATCH v2 3/9] provide in-kernel ioapic, Gleb Natapov, 2009/10/09