|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [RFC PATCH v2 5/5] ne2k_isa: add property for option rom loading. |
Date: | Wed, 07 Oct 2009 15:21:23 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4 |
On 10/07/09 15:08, Anthony Liguori wrote:
Gerd Hoffmann wrote:+ if (s->pxe) { + if (rom_add_option("pxe-ne2k_isa.bin") != 0) { + qemu_error("warning: loading rom pxe-ne2k_isa.bin failed\n"); + s->pxe = 0; + } + } +Maybe we should make the filename a property instead of adding a pxe option?
No. The user should not need to know the file name of the option rom just to enable pxe booting for the nic.
When making the filename configurable it should be a separate property like "rom-name" or simliar. I would suggest to NOT implement it unless users actually ask for it ;)
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |