[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/7] Warn if value of qdev_init() isn't checked
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 6/7] Warn if value of qdev_init() isn't checked |
Date: |
Wed, 7 Oct 2009 01:16:00 +0200 |
After qdev_init() fails, the device is gone. Failure to check runs a
high risk of use-after-free.
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/qdev.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/qdev.h b/hw/qdev.h
index b385b25..8cd843e 100644
--- a/hw/qdev.h
+++ b/hw/qdev.h
@@ -100,7 +100,7 @@ struct CompatProperty {
DeviceState *qdev_create(BusState *bus, const char *name);
DeviceState *qdev_device_add(QemuOpts *opts);
-int qdev_init(DeviceState *dev);
+int qdev_init(DeviceState *dev) __attribute__((warn_unused_result));
void qdev_init_nofail(DeviceState *dev);
int qdev_unplug(DeviceState *dev);
void qdev_free(DeviceState *dev);
--
1.6.2.5
- [Qemu-devel] [PATCH 0/7] Clean up use of qdev_init(), Markus Armbruster, 2009/10/06
- [Qemu-devel] [PATCH 6/7] Warn if value of qdev_init() isn't checked,
Markus Armbruster <=
- [Qemu-devel] [PATCH 3/7] Check return value of qdev_init(), Markus Armbruster, 2009/10/06
- [Qemu-devel] [PATCH 4/7] New qdev_init_nofail(), Markus Armbruster, 2009/10/06
- [Qemu-devel] [PATCH 1/7] Unbreak USB autoconnect filters, Markus Armbruster, 2009/10/06
- [Qemu-devel] [PATCH 2/7] Make qdev_init() destroy the device on failure, Markus Armbruster, 2009/10/06
- [Qemu-devel] [PATCH 7/7] Clean up test for qdev_init() failure, Markus Armbruster, 2009/10/06
- [Qemu-devel] [PATCH 5/7] Make isa_create() terminate program on failure, Markus Armbruster, 2009/10/06