Re: [Qemu-devel] Re: [PATCH 0/2] fix virtio_blk serial pci config breakage

[john cooper]

Paul Brook wrote:

> Agreed. If we're going to copy anything than my vote would be for SCSI. We 
> already have partial support for feeding SCSI commands to a virtio device.
> TBH I wouldn't have bothered with virtio-blk at all, and gone straight for 
> virtio-scsi. I guess it's a bit late for that though.

Initially the patch introduced a dedicated ioctl
in the guest driver to retrieve this data.  Review
comments from that version suggested using an
existing interface which to me seemed reasonable.

I had looked first at implementing the above via
a scsi INQUIRY cmd.   But at least at that time
this option would have been more invasive to the
existing code vs. just doing the equivalent via
an ATA HDIO_GET_IDENTITY.

-john

--
address@hidden