|
From: | Avi Kivity |
Subject: | [Qemu-devel] Re: [PATCH v1 00/14]: Initial QObject conversion |
Date: | Sat, 03 Oct 2009 09:59:39 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3 |
On 10/01/2009 11:21 PM, Luiz Capitulino wrote:
Regarding info, I think the machine protocol should manage it as separate commands ("info-cpus" instead of "info"("cpus")). Having a function which returns wildly different return types (a string for version, a device tree for qdev) is unwieldy.I agree and I think this approach would make my life easier.
I was thinking more of client writers.
The problem though is how to properly refactor the code so that we don't conflict with the user's 'info cpus' command. I will think about it, but would be good to decide this before mass conversion.
One approach would be to have two command tables, one for ordinary commands and one for info commands. The machine monitor can scan the two tables sequentially, while the human monitor will only scan the first table, and the second as a response to an 'info' command.
-- Do not meddle in the internals of kernels, for they are subtle and quick to panic.
[Prev in Thread] | Current Thread | [Next in Thread] |