[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/9] pci: use uint64_t for bar addr and size ins
Re: [Qemu-devel] [PATCH 4/9] pci: use uint64_t for bar addr and size instead of uint32_t.
Thu, 1 Oct 2009 22:46:27 +0400 (MSD)
On Thu, 1 Oct 2009, Anthony Liguori wrote:
> malc wrote:
> > I don't understand this at all. POSIX says that if you include any of
> > it's headers be prepared to deal with it, i.e. any of your own
> > typedefs that end with _t are potentially clashing with what's defined
> > there, similarly identifiers that start with 'str', 'E', double
> > underscore and underscore followed by a capital letter are reserved by
> > C, you just don't go there.
> _t is used pervasively throughout the code right now. In particular, we have
> ram_addr_t and target_phys_addr_t. pci_addr_t is a logical addition.
> I do agree that adhering to Posix is a good thing, but I think either we have
> to go through and fixup all of the _t's in the code today, or just accept the
> fact that we don't strictly adhere to Posix and deal with it if we ever have
> The middle ground where we don't allow new uses of _t but keep the old ones is
> just going to result in mass confusion and bike shedding.
Agreed. Let's see how removing it will not lead to bike shedding.