[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Improve error reporting on file access
From: |
Mark McLoughlin |
Subject: |
Re: [Qemu-devel] [PATCH] Improve error reporting on file access |
Date: |
Thu, 01 Oct 2009 17:12:52 +0100 |
On Thu, 2009-10-01 at 09:42 -0500, Justin M. Forbes wrote:
> Author: Justin M. Forbes <address@hidden>
> Date: Thu Oct 1 09:34:56 2009 -0500
>
> Improve error reporting on file access
>
> By making the error reporting include strerror(errno), it gives the user
> a bit more indication as to why qemu failed. This is particularly
> important for people running qemu as a non root user.
>
> Signed-off-by: Justin M. Forbes <address@hidden>
Certainly looks sensible to me
Not having this is hurting us in Fedora 12 because we've started running
qemu as an unprivileged user and people are having a hard time figuring
out the various errors they're seeing caused by the change. This should
help them.
Only concern is that errno might not be getting propagated correctly by
some of these functions, but we can fix that later if so.
Cheers,
Mark.