Re: [Qemu-devel] Re: CODING_STYLE (was Re: [PATCHv2] qemu: target library, use it in msix)

[Michael S. Tsirkin]

On Thu, Oct 01, 2009 at 11:10:12AM +0200, Kevin Wolf wrote:
> Am 01.10.2009 10:58, schrieb Michael S. Tsirkin:
> > On Thu, Oct 01, 2009 at 10:43:16AM +0200, Kevin Wolf wrote:
> >> Am 01.10.2009 08:17, schrieb Michael S. Tsirkin:
> >>> On Wed, Sep 30, 2009 at 04:01:00PM -0500, Anthony Liguori wrote:
> >>>> Blue Swirl wrote:
> >>>>> On Wed, Sep 30, 2009 at 8:00 PM, Avi Kivity <address@hidden> wrote:
> >>>>>   
> >>>>>> On 09/30/2009 03:51 PM, Michael S. Tsirkin wrote:
> >>>>>>     
> >>>>>>> So ... Linux kernel style wins? What do others think?
> >>>>>>>
> >>>>>>>       
> >>>>>> Any change is going to cause a large amount of pain if implemented.
> >>>>>>     
> >>>>>
> >>>>> True, but with 'indent' support the pain would be brief.
> >>>>>   
> >>>>
> >>>> It's equivalent to losing a massive amount of revision history which  
> >>>> hurts debugging.
> >>>
> >>> It is? Why is it? git bisect still works. what else do you use
> >>> for debugging that gets broken?
> >>
> >> git blame.
> >>
> >> Kevin
> > 
> > I think git blame has "-w" flag to ignore whitespace changes.
> 
> Are we only talking about changing the indentation?  Switching from 4
> spaces to tabs of 8 characters also means additional line breaks and so
> on (or does it handle these, too?). And I thought I read in this thread
> about braces, typedefs and probably some more things. Can -w really
> handle all of them?
> 
> Kevin

No. But if a line is very long, any code refactoring
will create the same effect. Most lines arent that long.

-- 
MST