[Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state

[Juan Quintela]

malc <address@hidden> wrote:
>> >> There are more temporary variables in other devices, and this was the
>> >> way it was done there.  Normally I would have called it active_vmstate
>> >> to make that explicit, but here, it was also used for reset, that is the
>> >> way I named it with the _vmstate suffix.
>> >
>> > In any case the while i can understand the fear of malloc, nobody forces
>> > you to do that you can have a scratch space on the stack, with an some
>> > upper cap, that's the way it's done now anyhow, only the cap is stack size
>> > reserved for the process and not something you have to choose.
>> 
>> You call new way a monstrosity, and now propose a solution that makes
>> the monster bigger?
>> 
>> I still stand behind the patch, and I still want it applied.
>> 
>
> And it wont be, not this part of it, not in this state.

Suggestions?  Because you are not telling me that you expect to move
something to the stack, reimplement alloca() and work from there was a
_real suggestion_?

Later, Juan.