[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/7] Add -Wold-style-declaration -Wold-style-def
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 6/7] Add -Wold-style-declaration -Wold-style-definition to QEMU_CFLAGS |
Date: |
Wed, 23 Sep 2009 18:09:25 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) |
Laurent Desnogues <address@hidden> writes:
> On Wed, Sep 23, 2009 at 1:19 AM, Juan Quintela <address@hidden> wrote:
>> ANSI c89 has been with us for a while.
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> configure | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 62dccd2..81b9ba8 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1648,6 +1648,7 @@ if test "$debug" = "no" ; then
>> fi
>> QEMU_CFLAGS="-Wall -Wundef -Wendif-labels -Wwrite-strings
>> -Wmissing-prototypes $QEMU_CFLAGS"
>> QEMU_CFLAGS="-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS"
>> +QEMU_CFLAGS="-Wold-style-declaration -Wold-style-definition $QEMU_CFLAGS"
>
> Some older versions of gcc don't handle -Wold-style-declaration.
> For instance gcc 4.1.2.
Pretty old, do we want to support it? If yes, make configure detect
whether the warning works?
- [Qemu-devel] [PATCH 0/7] Remove pre ANSI c89 code, Juan Quintela, 2009/09/22
- [Qemu-devel] [PATCH 4/7] gcc wants 1st static and then const, Juan Quintela, 2009/09/22
- [Qemu-devel] [PATCH 2/7] static and inline should came before the type of the functions, Juan Quintela, 2009/09/22
- [Qemu-devel] [PATCH 1/7] Use proper typedef syntax, Juan Quintela, 2009/09/22
- [Qemu-devel] [PATCH 3/7] Bring two last users of K&R definitions to ANSI c89, Juan Quintela, 2009/09/22
- [Qemu-devel] [PATCH 5/7] __thread should be before real type, Juan Quintela, 2009/09/22
- [Qemu-devel] [PATCH 6/7] Add -Wold-style-declaration -Wold-style-definition to QEMU_CFLAGS, Juan Quintela, 2009/09/22
[Qemu-devel] [PATCH 7/7] Remove PARAMS() macro, Juan Quintela, 2009/09/22
Re: [Qemu-devel] [PATCH 0/7] Remove pre ANSI c89 code, Markus Armbruster, 2009/09/23