qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] [RESEND2] Qemu unmaintained?


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] [RESEND2] Qemu unmaintained?
Date: Sun, 13 Sep 2009 19:19:15 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Thunderbird/3.0b3

On 09/10/2009 11:36 PM, Mark McLoughlin wrote:
On Thu, 2009-09-10 at 21:40 +0300, Avi Kivity wrote:

(and we're quite far from catching every regression btw).
That's kind of my point. A lot of regressions are only found after
they've been pushed. Delaying a push delays finding those regressions.

That makes sense if the regression tests don't find any regressions. If they do, then pushing despite those regressions means everyone is now hitting the regressions, swearing, and trying to work around them. We get massive parallelism but little progress.

Don't get me wrong - we certainly want to avoid regressions and doing
some testing before pushing is a good idea, but there is a balance to be
struck.

It's also the case that not all patches are equal. It should be possible
to short-cut the process for small patches, or regression fixes, or
patches from a trusted author who has done significant testing already.

I think reducing the batch size will also help. If the batch contains 100 patches there's a high likelihood of a regression in there. If you're testing 10-15 patches at a time it may actually work, and if not, you can easily guess who the offender is.

--
error compiling committee.c: too many arguments to function





reply via email to

[Prev in Thread] Current Thread [Next in Thread]