[Qemu-devel] Re: [PATCH 1/5] monitor: Add user_print() to mon_cmd_t

[Luiz Capitulino]

On Thu, 03 Sep 2009 20:55:51 +0200
Juan Quintela <address@hidden> wrote:

> Luiz Capitulino <address@hidden> wrote:
> > This new struct member will store a pointer to a function that
> > should be used to output data in the user protocol format.
> >
> > Additionally, it will also serve as a flag to say if a given
> > handler has already been ported to support the machine protocol.
> >
> > Signed-off-by: Luiz Capitulino <address@hidden>
> > ---
> >  monitor.c       |   69 +++++++++++++++---------------
> >  qemu-monitor.hx |  124 
> > ++++++++++++++++++++++++++++--------------------------
> >  2 files changed, 99 insertions(+), 94 deletions(-)
> >
> > diff --git a/monitor.c b/monitor.c
> > index a242b4b..b43a287 100644
> > --- a/monitor.c
> > +++ b/monitor.c
> > @@ -71,6 +71,7 @@ typedef struct mon_cmd_t {
> >      const char *name;
> >      const char *args_type;
> >      void *handler;
> > +    void (*user_print)(Monitor *mon, const QObject *data);
> >      const char *params;
> >      const char *help;
> >  } mon_cmd_t;
> > @@ -1807,80 +1808,80 @@ static const mon_cmd_t mon_cmds[] = {
> >  
> >  /* Please update qemu-monitor.hx when adding or changing commands */
> >  static const mon_cmd_t info_cmds[] = {
> 
> Once that your are changing all of them, could you use c99 initializers,
> that way it is easier to see what the action is.

 Yeah, I will do that for the real submission.