Re: [Qemu-devel] [PATCH 2/2] Build *-user targets as PIE

[Rtp]

"Kirill A. Shutemov" <address@hidden> writes:

> On Wed, Sep 2, 2009 at 6:46 PM, Arnaud Patard<address@hidden> wrote:
>> "Kirill A. Shutemov" <address@hidden> writes:
>>
>> Hi,
>>
>> [...]
>>
>>> diff --git a/configure b/configure
>>> index 0d0162a..b501526 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -2302,6 +2302,11 @@ if test "$target_softmmu" = "yes" ; then
>>>    esac
>>>  fi
>>>
>>> +if test "$target_user_only" = "yes" -a "$static" = "no" ; then
>>> +  cflags="-fpie $cflags"
>>> +  ldflags="-pie $ldflags"
>>> +fi
>>> +
>>
>> Please do that on per-arch basis. For instance, pie support tends to
>> be broken quite often on mips (afaik, it's currently broken on debian
>> unstable). I know qemu doesn't support mips host but it doesn't mean it
>> will never be supported - I need to find time to update to current git
>> and fix remaining bugs in my code before sending it for merge.
>> Unfortunately, this kind of patch will make sure it won't happen soon :(
>>
>>
>> Thanks,
>> Arnaud
>>
>
> Will you happy if I provide option like --disable-user-pie to configure?

yes, it's fine as I hope that pie support will be fixed.

>
> P.S. Sorry I forgot to put qemu-devil into CC.

qemu-_devil_ ? :)


Arnaud