[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 26/29] Introduce QInt unit-tests
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 26/29] Introduce QInt unit-tests |
Date: |
Mon, 31 Aug 2009 11:43:54 -0300 |
On Mon, 31 Aug 2009 09:55:53 +0200
Kevin Wolf <address@hidden> wrote:
> Luiz Capitulino schrieb:
> > This suite contains tests to assure that QInt API works as expected.
> >
> > To execute it you should have check installed and build QEMU with
> > check support enabled (--enable-check-utests) and then run:
> >
> > $ ./check-qint
> >
> > Signed-off-by: Luiz Capitulino <address@hidden>
> > ---
> > Makefile | 2 +
> > check-qint.c | 110
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > configure | 2 +-
> > 3 files changed, 113 insertions(+), 1 deletions(-)
> > create mode 100644 check-qint.c
>
> Shouldn't these tests better go in some subdirectory like tests/qobjects?
I've tried to have them in tests/ but was unable to get them
building.
As I was spending much time on this I gave up.
> > diff --git a/Makefile b/Makefile
> > index 983fe39..d08df6c 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -181,6 +181,8 @@ qemu-io$(EXESUF): qemu-io.o qemu-tool.o cmd.o
> > $(block-obj-y)
> > qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx
> > $(call quiet-command,sh $(SRC_PATH)/hxtool -h < $< > $@," GEN $@")
> >
> > +check-qint: check-qint.o qint.o qemu-malloc.o
> > +
> > clean:
> > # avoid old build problems by removing potentially incorrect old files
> > rm -f config.mak config.h op-i386.h opc-i386.h gen-op-i386.h op-arm.h
> > opc-arm.h gen-op-arm.h
> > diff --git a/check-qint.c b/check-qint.c
> > new file mode 100644
> > index 0000000..ae5d22f
> > --- /dev/null
> > +++ b/check-qint.c
> > @@ -0,0 +1,110 @@
> > +/*
> > + * QInt unit-tests.
> > + *
> > + * Copyright (C) 2009 Red Hat Inc.
> > + *
> > + * Authors:
> > + * Luiz Capitulino <address@hidden>
> > + */
>
> No license?
This will sound silly, but they are so simple that I didn't
mind adding the license text there.
Will do once they are merged or if a respin is needed.
- [Qemu-devel] [PATCH 18/29] monitor: Port handler_10 to use QDict, (continued)
- [Qemu-devel] [PATCH 18/29] monitor: Port handler_10 to use QDict, Luiz Capitulino, 2009/08/28
- [Qemu-devel] [PATCH 19/29] monitor: Split monitor_handle_command(), Luiz Capitulino, 2009/08/28
- [Qemu-devel] [PATCH 20/29] monitor: Drop unused macros, Luiz Capitulino, 2009/08/28
- [Qemu-devel] [PATCH 21/29] monitor: Drop str_allocated[], Luiz Capitulino, 2009/08/28
- [Qemu-devel] [PATCH 22/29] monitor: Drop args[] handling code, Luiz Capitulino, 2009/08/28
- [Qemu-devel] [PATCH 23/29] monitor: fail when 'i' type is greater than 32-bit, Luiz Capitulino, 2009/08/28
- [Qemu-devel] [PATCH 24/29] monitor: Update supported types documentation, Luiz Capitulino, 2009/08/28
- [Qemu-devel] [PATCH 25/29] Add check support, Luiz Capitulino, 2009/08/28
- [Qemu-devel] [PATCH 26/29] Introduce QInt unit-tests, Luiz Capitulino, 2009/08/28
- [Qemu-devel] [PATCH 27/29] Introduce QString unit-tests, Luiz Capitulino, 2009/08/28
- [Qemu-devel] [PATCH 28/29] Introduce QDict test data file, Luiz Capitulino, 2009/08/28
- [Qemu-devel] [PATCH 29/29] Introduce QDict unit-tests, Luiz Capitulino, 2009/08/28