[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [Qemu-commits] [COMMIT 5c6c3a6] raw-posix: add Linux na
From: |
Christoph Hellwig |
Subject: |
[Qemu-devel] Re: [Qemu-commits] [COMMIT 5c6c3a6] raw-posix: add Linux native AIO support |
Date: |
Fri, 28 Aug 2009 17:00:08 +0200 |
User-agent: |
Mutt/1.3.28i |
On Fri, Aug 28, 2009 at 03:07:33PM +0300, Riku Voipio wrote:
> use_aio is only ever set in CONFIG_LINUX_AIO protected section, so the #else
> section is not needed. Even if that were not the case, falling back to
> paio_submit()
> feels like a better idea than aborting emulation.
>
> fwiw, s->use_aio is a bad name as well, as it refers to linux aio, while the
> file also supports posix aio...
Yes. it was more of a quick hack. I just wanted to get a working patch
out ASAP as I expect a long discussion about how to correctly set the
flag to use and other bikesheds. I can send a version that just stores
the bdrv_ flags in the raw state and we can check that.