[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: Extending virtio_console to support multiple ports
From: |
Amit Shah |
Subject: |
[Qemu-devel] Re: Extending virtio_console to support multiple ports |
Date: |
Wed, 26 Aug 2009 16:57:18 +0530 |
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On (Tue) Aug 25 2009 [11:47:20], Amit Shah wrote:
>
> Hello all,
>
> Here is a new iteration of the patch series that implements a
> transport for guest and host communications.
>
> The code has been updated to reuse the virtio-console device instead
> of creating a new virtio-serial device.
And the problem now is that hvc calls the put_chars function with
spinlocks held and we now allocate pages in send_buf(), called from
put_chars.
A few solutions:
- Keep things as they are, virtio_console.c remains as it is and
virtio_serial.c gets added
- Have separate write paths for console devices in virtio_console.c,
which would beat the purpose of merging the two drivers and then
they'd be better off standalone
- Convert hvc's usage of spinlocks to mutexes. I've no idea how this
will play out; I'm no expert here. But I did try doing this and so far
it all looks OK. No lockups, lockdep warnings, nothing. I have full
debugging enabled. But this doesn't mean it's right.
Comments?
Amit
- [Qemu-devel] Extending virtio_console to support multiple ports, Amit Shah, 2009/08/25
- [Qemu-devel] [PATCH] virtio_console: Add interface for guest and host communication, Amit Shah, 2009/08/25
- [Qemu-devel] [PATCH 3/3] virtio-console: Add interface for generic guest-host communication, Amit Shah, 2009/08/25
- [Qemu-devel] Re: Extending virtio_console to support multiple ports,
Amit Shah <=
- [Qemu-devel] Re: Extending virtio_console to support multiple ports, Amit Shah, 2009/08/26
- [Qemu-devel] Re: Extending virtio_console to support multiple ports, Benjamin Herrenschmidt, 2009/08/27
- Re: [Qemu-devel] Re: Extending virtio_console to support multiple ports, Amit Shah, 2009/08/27
- [Qemu-devel] Re: Extending virtio_console to support multiple ports, Alan Cox, 2009/08/28
- [Qemu-devel] Re: Extending virtio_console to support multiple ports, Benjamin Herrenschmidt, 2009/08/27
- [Qemu-devel] [PATCH] hvc_console: provide (un)locked version for hvc_resize(), Hendrik Brueckner, 2009/08/28
- Re: [Qemu-devel] Re: Extending virtio_console to support multiple ports, Jamie Lokier, 2009/08/28
- [Qemu-devel] Re: Extending virtio_console to support multiple ports, Michael Ellerman, 2009/08/28
- [Qemu-devel] Re: Extending virtio_console to support multiple ports, Amit Shah, 2009/08/27
- [Qemu-devel] Re: Extending virtio_console to support multiple ports, Ryan Arnold, 2009/08/28