Re: [Qemu-devel] [PATCH 2/3] Clean up upcast from PCIDevice to I6300State

[Gerd Hoffmann]

  Hi,

> play.  However, the *next* commit (conversion to qdev) is wrong if qdev
> requires the PCIDevice at offset zero (not obvious to me, document it?).

qdev_create() allocates DeviceInfo->size bytes for you and assumes 
DeviceState starts at offset zero of your FooDeviceState.  I think that 
is the only place though.

Could probably be relaxed by adding a offset field to DeviceInfo, but I 
don't think that buys us much, so unless there is some real need I'd 
just go with the "DeviceState must be first" convention.

It also could be that there is some old code which does casts instead of 
using DO_UPCAST, especially for PCI because PCIDevice predates qdev. 
That I'd consider a bug though.

cheers,
  Gerd