|
From: | Juan Quintela |
Subject: | [Qemu-devel] Re: [PATCH 07/22] ne2000: Remove unneeded double indirection of PCINE2000State |
Date: | Mon, 24 Aug 2009 14:51:27 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Gerd Hoffmann <address@hidden> wrote: >> typedef struct NE2000State { >> + PCIDevice dev; >> uint8_t cmd; > >> -typedef struct PCINE2000State { >> - PCIDevice dev; >> - NE2000State ne2000; >> -} PCINE2000State; > > NACK. > > We'll have a ... > > typedef struct ISANE2000State { > ISADevice dev; > NE2000State ne2000; > } ISANE2000State; > > ... some day. Ok, redoing it this way. Thanks for the review. Later, Juan.
[Prev in Thread] | Current Thread | [Next in Thread] |