[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 03/14] configure stellaris device only for arm s
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 03/14] configure stellaris device only for arm softmmu |
Date: |
Fri, 21 Aug 2009 11:11:08 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Paolo Bonzini <address@hidden> wrote:
>> # What drivers should we compile
>> ssi_bus=no
>> +stellaris=no
>
> What about calling these CONFIG_SSI CONFIG_STELLARIS etc. already in
> configure, and initializing them with
>
> : ${CONFIG_SSI=n}
> : ${CONFIG_STELLARIS=n}
>
>> @@ -2236,6 +2238,10 @@ if test "$ssi_bus" = "yes" ; then
>> echo "CONFIG_SSI=y">> $config_host_mak
>> fi
>>
>> +if test "$stellaris" = "yes" ; then
>> + echo "CONFIG_STELLARIS=y">> $config_host_mak
>> +fi
>
> Then you can:
>
> 1) save duplication using
>
> for i in CONFIG_SSI CONFIG_STELLARIS; do
> case \$$i in
> if test "$config_var" = y; then
> echo "$i=y">> $config_host_mak
> fi
> done
>
> 2) allow the user to force your choice by setting environment
> variables when calling configure (not sure how useful this is).
>
> Otherwise, looks nice!
I would do the other way around :)
I.e. always print
CONFIG_STELLARIS=y
or
CONFIG_STELLARIS=n
That will move from 3 lines to 1 line.
About the big problem, is that in configure, we have 2 kinds of
variables:
- configure variables: usually lowercase
- variables for build system: usually uppercase
Notice that current code does a mess at distinguishing them, it _mainly_
is the way I have described. About your way, perhaps itis a better
idea, to _always_ use the configure names, that way we don't have to
"translate" from one name to the other.
Later, Juan.
- [Qemu-devel] [PATCH 00/14] Compile only devices that are used, Juan Quintela, 2009/08/20
- [Qemu-devel] [PATCH 01/14] Generate config-host.h after dealing with all the targets, Juan Quintela, 2009/08/20
- [Qemu-devel] [PATCH 02/14] Configure ssi bus and devices only if arm-softmmu target is selected, Juan Quintela, 2009/08/20
- [Qemu-devel] [PATCH 03/14] configure stellaris device only for arm softmmu, Juan Quintela, 2009/08/20
- [Qemu-devel] [PATCH 04/14] configure nseries devices only for arm softmmu, Juan Quintela, 2009/08/20
- [Qemu-devel] [PATCH 06/14] configure sd flash only for arm softmmu, Juan Quintela, 2009/08/20
- [Qemu-devel] [PATCH 07/14] configure ptimer only for arm and sparc softmmu, Juan Quintela, 2009/08/20
- [Qemu-devel] [PATCH 05/14] configure spitz devices only for arm softmmu, Juan Quintela, 2009/08/20
- [Qemu-devel] [PATCH 08/14] configure m48t59 only for sparc* and ppc softmmu, Juan Quintela, 2009/08/20
- [Qemu-devel] [PATCH 09/14] configure escc only for sparc and ppc softmmu, Juan Quintela, 2009/08/20
- [Qemu-devel] [PATCH 10/14] configure esp only for mips_jazz and sparc softmmu, Juan Quintela, 2009/08/20
- [Qemu-devel] [PATCH 11/14] configure ecc flash only for arm and sparc softmmu, Juan Quintela, 2009/08/20