Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT 5ba6531] user: compile ioport-user.c only for x86

[Blue Swirl]

On Sat, Aug 15, 2009 at 12:50 PM, Filip Navara<address@hidden> wrote:
> On Sat, Aug 15, 2009 at 11:30 AM, Anthony Liguori<address@hidden> wrote:
>> From: Blue Swirl <address@hidden>
>>
>> Signed-off-by: Blue Swirl <address@hidden>
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index 93c555b..74f869d 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -87,13 +87,17 @@ 
>> VPATH+=:$(SRC_PATH)/linux-user:$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR)
>>  QEMU_CFLAGS+=-I$(SRC_PATH)/linux-user 
>> -I$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR)
>>
>>  obj-y = main.o syscall.o strace.o mmap.o signal.o thunk.o \
>> -      elfload.o linuxload.o uaccess.o envlist.o gdbstub.o gdbstub-xml.o \
>> -      ioport-user.o
>> +      elfload.o linuxload.o uaccess.o envlist.o gdbstub.o gdbstub-xml.o
>> +
>>  obj-$(TARGET_HAS_BFLT) += flatload.o
>>  obj-$(TARGET_HAS_ELFLOAD32) += elfload32.o
>>
>>  obj-$(TARGET_I386) += vm86.o
>>
>> +ifeq ($(TARGET_BASE_ARCH), i386)
>> +obj-y += ioport-user.o
>> +endif
>
> Shouldn't this be just
>
> obj-$(TARGET_I386) += ioport-user.o
>
> ?

No, because TARGET_I386 is not defined for x86_64. If there was
TARGET_BASE_I386 (or similar) which was either 'y' or undefined, this
could be changed to

obj-$(TARGET_BASE_I386) += ioport-user.o

We could of course have
obj-$(TARGET_I386) += ioport-user.o
obj-$(TARGET_X86_64) += ioport-user.o

But I trust Juan will rearrange this anyway. :-)