[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: save/restore broken?
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: save/restore broken? |
Date: |
Thu, 13 Aug 2009 21:23:02 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) |
Luiz Capitulino <address@hidden> wrote:
> On Tue, 11 Aug 2009 18:39:47 +0200
> Paolo Bonzini <address@hidden> wrote:
>
>> Hi all,
>>
>> if I try to save and restore an image using current qemu and current
>> libvirt, the load fails.
>
> Yes, it's broken. I'm unable to loadvm and to migrate.
>
> According to git bisect the problem was introduced by:
>
> """
> commit 93c8cfd9e67a62711b86f4c93747566885eb7928
> Author: Gleb Natapov <address@hidden>
> Date: Sun Aug 2 11:36:47 2009 +0300
>
> make windows notice media change
> """
>
> Indeed, reverting this fixes it for me.
>
> When I try to loadvm I get this error:
>
> """
> Unknown savevm section type 255
> Error -22 while loading VM state
> """
>
> The migration symptoms are different. Sometimes it
> prints the same message, sometimes it kind of works
> but gets strange behaviors.
This patch fixes it for me, could you take a look if it also fixes things for
you?
Thanks.
>From 1322dfad92766a402c341071b0d55be6e510ebb1 Mon Sep 17 00:00:00 2001
From: Juan Quintela <address@hidden>
Date: Thu, 13 Aug 2009 21:07:05 +0200
Subject: [PATCH] Fix migration, if we read a field, it is better if we wrote it
first
Signed-off-by: Juan Quintela <address@hidden>
---
hw/ide.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/ide.c b/hw/ide.c
index bebda7c..1e38ae3 100644
--- a/hw/ide.c
+++ b/hw/ide.c
@@ -2888,6 +2888,7 @@ static void ide_save(QEMUFile* f, IDEState *s)
qemu_put_8s(f, &s->sense_key);
qemu_put_8s(f, &s->asc);
+ qemu_put_8s(f, &s->cdrom_changed);
/* XXX: if a transfer is pending, we do not save it yet */
}
--
1.6.2.5