|
From: | Gerd Hoffmann |
Subject: | [Qemu-devel] Re: [PATCH] isa_reserve_irq() |
Date: | Wed, 12 Aug 2009 17:41:23 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
On 08/12/09 17:31, Jes Sorensen wrote:
On 08/12/2009 05:28 PM, Gerd Hoffmann wrote:Hmm, I don't think it makes sense to pull a dummy device out of thin air, isa_reserve_irq() will do fine. But it should be be clearly documented that this is for this special case and not-yet converted devices. qdev-ified devices should use the other isa_*_irq functions instead.Ok - do you want me to update the documentation, or is it fine as is then?
Would be great to update the commit message and also place a comment into the source code.
thanks, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |