Re: [Qemu-devel] [PATCH] eliminate errors about unused results in block/vpc.c

[Anthony Liguori]

Nathan Froyd wrote:
> These errors come up when compiling with gcc-4.3.3 and some older headers:
>
> /scratch/froydnj/qemu.git/block/vpc.c: In function 'vpc_create':
> /scratch/froydnj/qemu.git/block/vpc.c:514: error: value computed is not used
> /scratch/froydnj/qemu.git/block/vpc.c:516: error: value computed is not used
> /scratch/froydnj/qemu.git/block/vpc.c:517: error: value computed is not used
> /scratch/froydnj/qemu.git/block/vpc.c:566: error: value computed is not used
>
> Just add void casts to silence the compiler.
>
> Signed-off-by: Nathan Froyd <address@hidden>
>   

Adding code to silence warnings is never the right approach.  In this 
case, strncpy is the wrong function to use.  We should just be using memcpy.

Regards,

Anthony Liguori