Re: [Qemu-devel] [PATCH 2/2] qdev/core: add monitor command to list all drivers

[Avi Kivity]

On 08/03/2009 01:05 PM, Gerd Hoffmann wrote:
> On 08/02/09 16:10, Avi Kivity wrote:
> > On 07/29/2009 02:12 PM, Gerd Hoffmann wrote:
> > > diff --git a/monitor.c b/monitor.c
> > > index 99c174c..9093254 100644
> > > --- a/monitor.c
> > > +++ b/monitor.c
> > > @@ -1882,6 +1882,8 @@ static const mon_cmd_t info_cmds[] = {
> > > "", "show balloon information" },
> > > { "qtree", "", do_info_qtree,
> > > "", "show device tree" },
> > > + { "qdrv", "", do_info_qdrv,
> > > + "", "show qdev driver list" },
> > > { NULL, NULL, },
> > > };
> >
> > Drivers are guest things. You're listing device models, not drivers.
>
> Strictly speaking you are correct.  But qemu is quite sloppy here and 
> calls the device models drivers (almost?) everythere, so I'd tend to 
> stick with it for consistency ...

Consistently incorrect?

Given that it's an external ABI, let's not be sloppy here.

--
error compiling committee.c: too many arguments to function