Re: [Qemu-devel] [PATCH 2 of 3] a single vnc server surface

[Stefano Stabellini]

On Wed, 29 Jul 2009, Gerd Hoffmann wrote:
> On 07/29/09 16:40, Stefano Stabellini wrote:
> > On Wed, 29 Jul 2009, Gerd Hoffmann wrote:
> >> I doubt you did any copyrect testing.  It is broken in master[1], and
> >> this patch breaks it even more.
> >
> > No I didn't: I notice that your fix wasn't applied yet but can be easily
> > applied on top of this patch.
> 
> No, it can't.  Well, it will apply.  It will also build with the small 
> fixup.  But the code isn't correct then.
> 
> The complete workflow of your patch was appearently designed without 
> copyrect in mind.  The whole point of copyrect is to avoid sending 
> screen updates.  Your patch doesn't handle that at all.
> 

All right, all right, I'll resend #2 with your patch integrated in the
right way. and I'll test copyrect myself.