Re: [Qemu-devel] [PATCH 3 of 3] variable timer intervals

[Gerd Hoffmann]

On 07/29/09 14:09, Stefano Stabellini wrote:
> This patch introduces dynamic timer intervals: we slow down the refresh
> rate when there in no much activity but we get back to a fast refresh
> rate when the activity resume.

Looks good in principle.  Untested though because it doesn't apply 
without patch #2.

>           if (vs->output.offset&&  !vs->audio_cap&&  !vs->force_update)
>               /* kernel send buffers are full ->  drop frames to throttle */
> -            return;
> +            return 0;

Maybe it makes sense to integrate this throttle logic into the refresh 
rate adaption?

cheers,
  Gerd