qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 3/4] Use C99 initializers for audio_option


From: Juan Quintela
Subject: [Qemu-devel] Re: [PATCH 3/4] Use C99 initializers for audio_option
Date: Tue, 28 Jul 2009 10:22:38 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux)

Gerd Hoffmann <address@hidden> wrote:
> On 07/28/09 00:20, Juan Quintela wrote:
>> malc<address@hidden>  wrote:
>>> On Mon, 27 Jul 2009, Juan Quintela wrote:
>>>
>>> I'd prefer:
>>>
>>>         { .name  = "DAC_SIZE_IN_USEC",
>>>           .tag   = AUD_OPT_BOOL,
>>>           .valp  =&conf.size_in_usec_out,
>>>           .descr = "DAC period/buffer size in microseconds (otherwise in 
>>> frames)" },
>>>         { ...
>>>
>>> And likewise elsewhere.
>>
>> I tried to be consistent with the qdev patches, they add all its "arrays
>> of structures" this way (it is one of the bigger users of the feature
>> that I saw).
>
> I think malc refers to the vertical alignment, i.e.
>
>   .foo      = bar,
>   .longname = somethingelse,
>
> instead of
>
>   .foo = bar,
>   .longname = somethingelse,
>
> The version with the vertical aligned '=' is more readable IMO.

Ah, ok.
Re-sending what that fixed


> cheers,
>   Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]