Re: [Qemu-devel] [PATCH 3/4] PPC: Round VGA BIOS size to page boundary

[Alexander Graf]

On 25.07.2009, at 19:15, Blue Swirl wrote:

> On Sat, Jul 25, 2009 at 2:16 AM, Alexander Graf<address@hidden> wrote:
> > When giving KVM a slot of a size not on page boundary, it chokes.  
> > So let's
> > just round up the VGA BIOS size so nobody complains anymore and we  
> > don't need
> > to implement sub-page slots.
>
> > +
> > +        /* Round to page boundary */
> > +        vga_bios_size = (vga_bios_size + TARGET_PAGE_SIZE) &  
> > TARGET_PAGE_MASK;
>
> > +
> > +        /* Round to page boundary */
> > +        vga_bios_size = (vga_bios_size + TARGET_PAGE_SIZE) &  
> > TARGET_PAGE_MASK;
>
> This wrongly increases the size by extra TARGET_PAGE_SIZE, when
> vga_bios_size mod TARGET_PAGE_SIZE == 0. Please use (vga_bios_size +
> TARGET_PAGE_SIZE - 1) & TARGET_PAGE_MASK.

Right, that's what Jan said too. Mind to change it when applying the  
patch or would you prefer me to do a respin?

Alex