[Qemu-devel] Re: [PATCH] configure: fix breakage of --extra-{cflags, ldflags}

[Nathan Froyd]

On Thu, Jul 23, 2009 at 02:43:26PM +0200, Juan Quintela wrote:
> Jan Kiszka <address@hidden> wrote:
> >> -CFLAGS="$CFLAGS -Wall -Wundef -Wendif-labels -Wwrite-strings 
> >> -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls"
> >> -LDFLAGS="$LDFLAGS -g"
> >> +CFLAGS="$CFLAGS $EXTRA_CFLAGS -Wall -Wundef -Wendif-labels 
> >> -Wwrite-strings -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls"
> >> +LDFLAGS="$LDFLAGS $EXTRA_LDFLAGS -g"
> >
> > ...but now we add the extra flags twice. So please remove the injection
> > into the flags for $config_mak.
>
> It is still broken.  Thinking of a solution.
> People wanted EXTRA_CFLAGS to be added at the end of CFLAGS, not in the
> middle.  Trying to find a way that is consistent for everything.
>
> Could you told in what test do you need extra_cflags?

The particular instance was for detecting zlib in a cross
configuration.  But that's not necessarily the only test where
--extra-{cflags,ldflags} would be useful: every test that needs external
libraries is subject to this bug (zlib, TLS, SASL, SDL, VDE libraries,
BrlAPI?, Xen?, bluez?, etc.).

If adding EXTRA_{CFLAGS,LDFLAGS} to all such tests is necessary and
people feel that's the best solution, then I can do that.

-Nathan