Re: [Qemu-devel] [PATCH] RFC: TCG constant propagation.

[Laurent Desnogues]

On Thu, Jul 23, 2009 at 11:08 AM, Filip Navara<address@hidden> wrote:
> Also it looks that the actual code size is worse for TCG ARM target
> with this optimization. To mitigate it I propose the other attached
> patch which uses the barrel shifter for more optimal generation of the
> "movi" operation. I can't test it, so any help is welcome.

This is wrong for two reasons:
   - this is a rotation, you only check for shifts
   - the rotation amount is multiplied by 2 before being applied to the
     8-bit immediate field.


Laurent