[Qemu-devel] Re: [PATCH] kvm: Fix error detection for KVM_GET_DIRTY_LOG

[Anthony Liguori]

Jan Kiszka wrote:
> > That makes me uncomfortable.  Shouldn't we make kvm return something
> > that's exposed to userspace?
> >
> >     
>
> Yes, but we can't do this from user space :) (or in other words: there
> are already kernels out there which return this invalid code).
>   

But since it's not symbolic, at some point in time the meaning of 524 
can potentially change and introduce a very, very subtle bug.

> The situation would only be different if Alex said that it takes further
> kernel patches anyway to make his PowerPC targets work. Dunno.
>   

Certainly, his PPC target is not in any released kernel version so 
there's time to fix things properly.

> Jan
>
>   


--
Regards,

Anthony Liguori