|
From: | Anthony Liguori |
Subject: | [Qemu-devel] Re: [PATCH 1/2] Introduce CharDriverState qdev property type |
Date: | Tue, 21 Jul 2009 10:23:40 -0500 |
User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
Gerd Hoffmann wrote:
On 07/21/09 16:53, Anthony Liguori wrote:Gerd Hoffmann wrote:On 07/17/09 16:41, Anthony Liguori wrote:Signed-off-by: Anthony Liguori<address@hidden>Hmm, I think that goes into the wrong direction. Properties should not be pointers to internal qemu state. Yes, there is qemu_prop_ptr, but I consider that a temporary stopgap until we can do better. Instead CharDriverState's should get a name and we need a way to lookup them by name. Then we can store the name instead of a pointer into the property.Would you have a property type that was basically a char driver state name?Yes. Same for drives and others. A generic string property should do I think.
Couldn't a struct pointer be used for that though? It can still be exposed as a string to the user.
cheers, Gerd
-- Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |