|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] [PATCH 04/13] qdev: add generic qdev_device_add() |
Date: | Wed, 15 Jul 2009 08:26:35 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
On 07/15/09 01:43, Markus Armbruster wrote:
Gerd Hoffmann<address@hidden> writes:On 07/10/09 22:51, Paul Brook wrote:I think this is going in the wrong direction. The device tree provides us with a standard way of identifying which bus to add a device to. We should be removing uses of pci_create, not adding new ones.Why? Let me guess: Because pci bus numbers are guest-changeable and thus not stable?Because I don't think this code need to be bus specific.Parts of the problem are certainly bus-specific though, such as parsing bus addresses.Yes. Provide a bus method to parse the addr property?
Would be an option, yes. I plan to sort bus= first, then look how to solve the addr= puzzle.
-device lsi,bus=pci0,id=foo -device lsi,bus=pci0,id=bar -device scsi-disk,bus=pci0/foo/scsi -device scsi-disk,bus=pci0/bar/scsiWhy foo/scsi? Is there a node "scsi" between the lsi device and the disk? If yes, why?
scsi bus (and we can't skip it as a scsi adapter might have more than one bus).
Have hacked up something yesterday, will post RfC patch later today. cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |