qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value inst


From: Stuart Brady
Subject: Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int.
Date: Mon, 13 Jul 2009 22:19:05 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Mon, Jul 13, 2009 at 01:59:31PM -0500, Anthony Liguori wrote:
> If so, I would think that we should use ram_addr_t for addr and then we 
> can use the appropriate uintN_t type for value.  Switching value like 
> that though could have some subtle consequences.  For instance, 
> cpu_outb(env, ..., 128) would have worked properly before as would 
> cpu_outb(env, ..., -32).

Isn't ram_addr_t solely for return values from (and internals of)
qemu_ram_alloc() and friends?

Perhaps port IO addresses should have their own type?

TBH, I'm not so sure that port IO is particularly 'special' in any way.
I suppose that generally speaking, code can't be executed from port IO
addresses (although that's not true on machines where 'port IO' is
actually memory mapped).  I'm not sure how PCI fits into this, though.

Cheers,
-- 
Stuart Brady




reply via email to

[Prev in Thread] Current Thread [Next in Thread]