qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [Qemu-commits] [COMMIT 49e6637] Sparc32: convert eccmem


From: Paul Brook
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 49e6637] Sparc32: convert eccmemctl to qdev
Date: Sun, 12 Jul 2009 13:16:57 +0100
User-agent: KMail/1.11.4 (Linux/2.6.29-2-amd64; KDE/4.2.4; x86_64; ; )

> +static void ecc_register_devices(void)
> +{
> +    sysbus_register_dev("ecc", sizeof(ECCState), ecc_init1);
> +}

I suggest using a name that is a little less generic than "ecc". The device 
namespace is shared between all machines, and I'm pretty sure there are other 
ecc controllers out there. What does OpenFirmware call this device?

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]