Re: [Qemu-devel] [PATCH 3/5] Add getfd and closefd monitor commands

[Avi Kivity]

On 07/08/2009 07:03 PM, Mark McLoughlin wrote:
> > The _t namespace is reserved by posix and not used for structures in
> > qemu anyway.  I see there's precedent a few lines above but let's not
> > introduce new violations.
> >      
>
> Bah, where there's a number of different styles used in a code base, and
> where there's no guidelines in CODING_STYLE, I tend to stick with the
> style of the code I'm editing. And, in this case, the closest structure
> definition used this style.
>
>    

Naming is one of the few things CODING_STYLE does talk about.

> > > +
> > > +    fd = dup(fd);
> > >
> > >        
> > Why?
> >      
>
> Because it gets closed again after the chr_read() handler finishes. I
> guess we could make qemu_chr_get_msgfd() pass ownership of the fd to the
> caller.
>    

I'd prefer the communication layer to queue fds and getfd to dequeue them.

--
error compiling committee.c: too many arguments to function