Re: [Qemu-devel] [PATCH 3/3 v2] Add a pc-0-10 machine type for compatibility with 0.10.x

[Mark McLoughlin]

On Wed, 2009-07-08 at 16:09 +0200, Gerd Hoffmann wrote:
> On 07/08/09 15:44, Anthony Liguori wrote:
> > Gerd Hoffmann wrote:
> >>> +enum {
> >>> + COMPAT_DEFAULT = 0,
> >>> + COMPAT_0_10, /* compatible with qemu 0.10.x */
> >>> +};
> >>
> >> Hmm. Just digged in the virtio blk code. Noticed some ppc machines
> >> have virtio block devices too. So linking it to a machine type looks
> >> wrong to me.
> >
> > No, it's right. A machine type is nothing more than a default device
> > tree.
> 
> Plain "-M pc" has no virtio blk device.
> 
> > So basically, if we had device config files, it would look like:
> >
> > /usr/share/qemu/configs/pc-0-10.dts
> > /usr/share/qemu/configs/pc-0-11.dts
> > /usr/share/qemu/configs/pc -> /usr/share/qemu/configs/pc-0-11.dts
> 
> Doesn't work.  Your virtio blk device isn't in there.

Right - I had assumed Anthony meant that such a config file would also
have details on the defaults used for devices which can be added to that
machine.

Cheers,
Mark.