[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/6] pci.c: remove unnecessary #ifdef DEBUG_PCI.
From: |
Isaku Yamahata |
Subject: |
[Qemu-devel] [PATCH 1/6] pci.c: remove unnecessary #ifdef DEBUG_PCI. |
Date: |
Tue, 7 Jul 2009 15:59:22 +0900 |
remove unnecessary #ifdef DEBUG_PCI.
Signed-off-by: Isaku Yamahata <address@hidden>
---
hw/pci.c | 29 +++++++++++++++--------------
1 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 4458079..7ee9dde 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -28,6 +28,11 @@
#include "sysemu.h"
//#define DEBUG_PCI
+#ifdef DEBUG_PCI
+# define PCI_DPRINTF(format, ...) printf(format, __VA_ARGS__)
+#else
+# define PCI_DPRINTF(format, ...) do { } while (0)
+#endif
struct PCIBus {
BusState qbus;
@@ -540,9 +545,9 @@ void pci_data_write(void *opaque, uint32_t addr, uint32_t
val, int len)
PCIDevice *pci_dev;
int config_addr, bus_num;
-#if defined(DEBUG_PCI) && 0
- printf("pci_data_write: addr=%08x val=%08x len=%d\n",
- addr, val, len);
+#if 0
+ PCI_DPRINTF("pci_data_write: addr=%08x val=%08x len=%d\n",
+ addr, val, len);
#endif
bus_num = (addr >> 16) & 0xff;
while (s && s->bus_num != bus_num)
@@ -553,10 +558,8 @@ void pci_data_write(void *opaque, uint32_t addr, uint32_t
val, int len)
if (!pci_dev)
return;
config_addr = addr & 0xff;
-#if defined(DEBUG_PCI)
- printf("pci_config_write: %s: addr=%02x val=%08x len=%d\n",
- pci_dev->name, config_addr, val, len);
-#endif
+ PCI_DPRINTF("pci_config_write: %s: addr=%02x val=%08x len=%d\n",
+ pci_dev->name, config_addr, val, len);
pci_dev->config_write(pci_dev, config_addr, val, len);
}
@@ -591,14 +594,12 @@ uint32_t pci_data_read(void *opaque, uint32_t addr, int
len)
}
config_addr = addr & 0xff;
val = pci_dev->config_read(pci_dev, config_addr, len);
-#if defined(DEBUG_PCI)
- printf("pci_config_read: %s: addr=%02x val=%08x len=%d\n",
- pci_dev->name, config_addr, val, len);
-#endif
+ PCI_DPRINTF("pci_config_read: %s: addr=%02x val=%08x len=%d\n",
+ pci_dev->name, config_addr, val, len);
the_end:
-#if defined(DEBUG_PCI) && 0
- printf("pci_data_read: addr=%08x val=%08x len=%d\n",
- addr, val, len);
+#if 0
+ PCI_DPRINTF("pci_data_read: addr=%08x val=%08x len=%d\n",
+ addr, val, len);
#endif
return val;
}
--
1.6.0.2
- [Qemu-devel] [PATCH 0/6] pci: various clean up and 64bit bar support., Isaku Yamahata, 2009/07/07
- [Qemu-devel] [PATCH 6/6] pci: 64bit bar support., Isaku Yamahata, 2009/07/07
- [Qemu-devel] [PATCH 2/6] pci: use uint8_t for pci_register_bar() type argument of int., Isaku Yamahata, 2009/07/07
- [Qemu-devel] [PATCH 3/6] pci: minor clean up of pci_update_mappings()., Isaku Yamahata, 2009/07/07
- [Qemu-devel] [PATCH 4/6] pci: define a constant to represent a unmapped bar and use it., Isaku Yamahata, 2009/07/07
- [Qemu-devel] [PATCH 1/6] pci.c: remove unnecessary #ifdef DEBUG_PCI.,
Isaku Yamahata <=
- [Qemu-devel] [PATCH 5/6] pci: use uint64_t for bar addr and size instead of uint32_t., Isaku Yamahata, 2009/07/07