[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command accept f
From: |
Mark McLoughlin |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command accept file descriptors |
Date: |
Tue, 07 Jul 2009 09:13:07 +0100 |
On Tue, 2009-07-07 at 10:52 +0300, Avi Kivity wrote:
> On 07/07/2009 10:43 AM, Mark McLoughlin wrote:
> >
> >> (qemu) getfd foo
> >> (qemu) getfd bar
> >> (qemu) getfd baz
> >> (qemu) pci_add ...,fd=foo
> >> (qemu) pci_add ...,fd=bar ...,fd=baz
> >>
> >> A closefd command would be needed to deal with errors.
> >>
> >
> > Nice idea, certainly.
> >
> > However, since it's only currently useful for tap/socket networking, I'm
> > happier with not adding two new monitor commands and only supporting a
> > single fd for now.
> >
>
> What happens when we do get more commands?
Any specific ideas around what else might use it?
> Do we then add the new commands and special-case fd=msgfd ?
Sounds like a fine plan to me. We could name an fd passed via the
current commands as "msgfd" and only the "getfd" command would have the
ability to assign another name.
Cheers,
Mark.
- [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command accept file descriptors, Mark McLoughlin, 2009/07/06
- [Qemu-devel] [PATCH 1/3] Make tcp_chr_read() use recvmsg(), Mark McLoughlin, 2009/07/06
- Re: [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command accept file descriptors, Avi Kivity, 2009/07/07
- Re: [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command accept file descriptors, Mark McLoughlin, 2009/07/07
- Re: [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command accept file descriptors, Avi Kivity, 2009/07/07
- Re: [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command accept file descriptors,
Mark McLoughlin <=
- Re: [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command accept file descriptors, Avi Kivity, 2009/07/07
- Re: [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command accept file descriptors, Daniel P. Berrange, 2009/07/07
- Re: [Qemu-devel] [PATCH 0/3] Allow host_net_add monitor command accept file descriptors, Mark McLoughlin, 2009/07/08
- [Qemu-devel] [PATCH 1/5] Make tcp_chr_read() use recvmsg(), Mark McLoughlin, 2009/07/08
- [Qemu-devel] [PATCH 2/5] Add SCM_RIGHTS support to unix socket character devices, Mark McLoughlin, 2009/07/08
- [Qemu-devel] [PATCH 3/5] Add getfd and closefd monitor commands, Mark McLoughlin, 2009/07/08
- [Qemu-devel] [PATCH 4/5] Add monitor_get_fd() command for fetching named fds, Mark McLoughlin, 2009/07/08
- [Qemu-devel] [PATCH 5/5] Add support for fd=name to tap and socket networking, Mark McLoughlin, 2009/07/08
- Re: [Qemu-devel] [PATCH 3/5] Add getfd and closefd monitor commands, Avi Kivity, 2009/07/08
- Re: [Qemu-devel] [PATCH 3/5] Add getfd and closefd monitor commands, Mark McLoughlin, 2009/07/08