Re: [Qemu-devel] [PATCH 4/5] ATAPI pass through v2: bring the new ATAPI pass throug feature

[Christoph Hellwig]

On Wed, Jul 01, 2009 at 07:32:09PM +0100, Bique Alexandre wrote:
> This patch brings the new ATAPI pass through feature.

I really don't understand the need for the BDRV_TYPE_CDROM_PT block
device type.  The use of BDRV_TYPE_* is mostly a hint for ide/scsi
what kind of device where dealing with, and a passthrough CDROM should
be different from a real one.  I think we should just make any drive
that points to a hardware CDROM device use the passthrough code, similar
to how you'll get a hardware passthrough SCSI CDROM if you point the
-drive option to a /dev/sr* device for a host CDROM.