[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev |
Date: |
Tue, 30 Jun 2009 18:55:13 +0200 |
User-agent: |
Thunderbird 2.0.0.21 (X11/20090320) |
Christoph Hellwig schrieb:
> On Tue, Jun 30, 2009 at 03:37:17PM +0200, Kevin Wolf wrote:
>> Pass is_write = 1 to qcow_aio_setup when writing.
>
> Looks correct, sorry for introducing this.
>
> Maybe we should add symbolic names for READ/WRITE in another patch to
> make this more easily spottable?
I'd expect we'll not see such things in the same place again, but
symbolic constants are always better. Are you going to prepare a patch?
Kevin